London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 1|Analyse and Refactor#98
Open
fatmaevin wants to merge 8 commits intoCodeYourFuture:mainfrom
Open
London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 1|Analyse and Refactor#98fatmaevin wants to merge 8 commits intoCodeYourFuture:mainfrom
fatmaevin wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
added 8 commits
February 12, 2026 17:29
fatmaevin
added
the
Needs Review
cjyuan
reviewed
Feb 27, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Refactored code and analyses are good.
Maybe one overlooked case?
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity:To using nested loop for compare elements time complexity will be ---> O(n*n) | ||
| * Space Complexity:We only use few variables -->O(1) |
There was a problem hiding this comment.
Few variables means O(1) space complexity?
The space complexity in Sprint-1/JavaScript/findCommonItems/findCommonItems.js is O(n) even though it also uses a few variables.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist